Add missing await when executing fulfill actions#820
Merged
ryanio merged 1 commit intoProjectOpenSea:mainfrom Mar 11, 2026
Merged
Add missing await when executing fulfill actions#820ryanio merged 1 commit intoProjectOpenSea:mainfrom
ryanio merged 1 commit intoProjectOpenSea:mainfrom
Conversation
ryanio
approved these changes
Mar 11, 2026
Collaborator
ryanio
left a comment
ryanio
left a comment
There was a problem hiding this comment.
LGTM — both missing awaits are genuine bugs in the README examples. Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
awaitwhen callingexecuteAllFulfillActions()in the README examples.Previously, the function was invoked without awaiting the returned Promise, which could lead to incorrect behavior and confusion for users.
The examples now correctly await the transaction execution, ensuring the code works as expected and matches the async API design.